Skip to content

No need for infer projection hack in add_item_bounds_for_hidden_type #114303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

No need for infer projection hack in add_item_bounds_for_hidden_type #114303

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

Nothing in the UI test changes when we remove this... what happened? Do we just need a test?

@rustbot
Copy link
Collaborator

rustbot commented Jul 31, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 31, 2023
@compiler-errors
Copy link
Member Author

I guess we could crater to find out 🤔

@bors try

@bors
Copy link
Collaborator

bors commented Jul 31, 2023

⌛ Trying commit fbbdb0f with merge cc3ab42ab8c8d95d0402af74a12fb2e399767dd0...

@bors
Copy link
Collaborator

bors commented Jul 31, 2023

☀️ Try build successful - checks-actions
Build commit: cc3ab42ab8c8d95d0402af74a12fb2e399767dd0 (cc3ab42ab8c8d95d0402af74a12fb2e399767dd0)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-114303 created and queued.
🤖 Automatically detected try build cc3ab42ab8c8d95d0402af74a12fb2e399767dd0
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-114303 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-114303 is completed!
📊 4 regressed and 0 fixed (339003 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 2, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Aug 2, 2023

There's a single regression with a compiler infinite recursion: https://crater-reports.s3.amazonaws.com/pr-114303/try%23cc3ab42ab8c8d95d0402af74a12fb2e399767dd0/gh/JakeDawkins.graphql-client-302-repro/log.txt

The others are linker errors or out of disk-space issues.

@apiraino
Copy link
Contributor

If I am not wrong this can go back ti the author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2023
@apiraino apiraino removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 18, 2023
@adetaylor adetaylor mentioned this pull request Dec 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @bors @craterbot @oli-obk @apiraino